8358813: JPasswordField identifies spaces in password via delete shortcuts #25688

mickleness · 2025-06-09T02:36:44Z

There were a few action bindings available in JPasswordFields in Aqua that let you identify the boundaries of words.

This came to my attention while looking at the related work #25443 . In that PR we said we should iterate across all available L&Fs, so this PR copies that same approach. (The original complaint only focused on Aqua, though.)

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8358813: JPasswordField identifies spaces in password via delete shortcuts (Bug - P3)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Damon Nguyen (@DamonGuy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25688/head:pull/25688
$ git checkout pull/25688

Update a local copy of the PR:
$ git checkout pull/25688
$ git pull https://git.openjdk.org/jdk.git pull/25688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25688

View PR using the GUI difftool:
$ git pr show -t 25688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25688.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-09T02:37:35Z

👋 Welcome back mickleness! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-09T02:37:52Z

@mickleness This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358813: JPasswordField identifies spaces in password via delete shortcuts

Reviewed-by: aivanov, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

f95af74: 8364312: debug agent should set FD_CLOEXEC flag rather than explicitly closing every open file
72d1066: 8364722: Parallel: Move CLDG mark clearing to the end of full GC
0ceb366: 8356645: Javac should utilize new ZIP file system read-only access mode
... and 37 more: https://git.openjdk.org/jdk/compare/57553ca1dbc63e329116bc11764816a4c5ccb297...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@honkar-jdk, @aivanov-jdk, @DamonGuy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-06-09T02:38:21Z

@mickleness The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mickleness · 2025-06-09T02:40:02Z

IMO this PR is a simple response that interfaces with an existing method. I recommend this approach because it should be relatively low-risk, and it is based on existing precedent.

By contrast: #25443 does something more aggressive (and interesting). It replaces selectWordAction with selectLineAction. That looks (to me) like a more thorough/better approach to the general problem of accidentally interacting with words in a password field. This PR should resolve any KeyStroke-based actions, but in JDK-8354646 the original complaint had to do with double-clicking the mouse; so this PR wouldn't impact those steps.

I haven't explored this thoroughly yet, but glancing through the AccessibleJTextField suggests an AX interface could still have access (via AccessibleActions) to the word-related actions we're trying to restrict access to. If so: this problem (accessing words in a password field) keeps popping up, and removing/replacing the unwanted actions seems like the most thorough response.

(Also see JDK-6191897 and JDK-4231444 ).

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java

…est.java Co-authored-by: Andrey Turbanov <[email protected]>

mlbridge · 2025-06-27T22:38:12Z

Webrevs

honkar-jdk

There is a mismatch between the PR title and JBS title JDK-8358813.

aivanov-jdk · 2025-07-11T09:25:43Z

src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java

Please, update the copyright year.

This is no longer necessary after merging with master ( see 2bff8e0 )

aivanov-jdk · 2025-07-11T09:34:26Z

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java

+        for (int condition : new int[] {
+                JComponent.WHEN_IN_FOCUSED_WINDOW,
+                JComponent.WHEN_FOCUSED,
+                JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT
+        }) {


The array with input map types could be a static constant just above runTest method.

OK, this is updated.

aivanov-jdk · 2025-07-11T09:37:32Z

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java

+                if (actionBinding == DefaultEditorKit.deleteNextWordAction ||
+                        actionBinding == DefaultEditorKit.deletePrevWordAction ||
+                        actionBinding == DefaultEditorKit.beginWordAction ||
+                        actionBinding == DefaultEditorKit.endWordAction ||
+                        actionBinding == DefaultEditorKit.selectionBeginWordAction ||
+                        actionBinding == DefaultEditorKit.selectionEndWordAction ||
+                        actionBinding == DefaultEditorKit.previousWordAction ||
+                        actionBinding == DefaultEditorKit.nextWordAction ||
+                        actionBinding == DefaultEditorKit.selectionPreviousWordAction ||
+                        actionBinding == DefaultEditorKit.selectionNextWordAction ) {


Does it make sense to put the actions in a list or array? Then listOfActions.contains(actionBinding) instead of this long if condition?

I don't have a preference. I pushed an update that wraps them in a TreeSet.

aivanov-jdk · 2025-07-11T21:13:37Z

Client tests are green.

This is in response to: openjdk#25688 (comment)

DamonGuy

Tested with and without the change to AquaKeyBindings. Passes after adding null to the 3 key bindings. Ran on clientlibs tests and all tests still pass. I left a question on the bindings segment for clarification.

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java

DamonGuy · 2025-07-31T20:55:49Z

src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java

                        "shift alt KP_RIGHT", null,
+                        "alt BACK_SPACE", null,
+                        "ctrl W", null,
+                        "alt DELETE", null


The change "works" for the test, but I'm not exactly sure what's changed here. When I make my own local test with a JPasswordField, the key binds don't do anything on Aqua. The CTRL+W seems to just input W. ALT+BACK_SPACE seems to just backspace the character before the carat. Can you help me understand this?

Also, I guess you can end in a trailing comma to match the previous format if you want. Either is OK.

@DamonGuy it sounds like maybe (?) you're not able to reproduce the original ticket?

Here's a video showing what I experience in JDK 24 vs what I see when I use this PR:
https://go.screenpal.com/watch/cTjfh4nI55H

Does this match what you're observing/experiencing, and if not: what do you see instead?

@DamonGuy I can reproduce the problem with the test, PasswordSelectionWordTest.java, attached to JDK-8358813.

Also, I guess you can end in a trailing comma to match the previous format if you want. Either is OK.

This is a nice suggestion.

OK, I added a trailing comma

Thanks for the video showcase. I was catching up yesterday after being out and I can now see the issue. I can match what is shown now as well. I might have built the image with incomplete changes the first go around.

…est.java Co-authored-by: DamonGuy <[email protected]>

aivanov-jdk · 2025-08-05T20:11:25Z

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java

+    /**
+     * These are all the actions with "word" in their field name.
+     */
+    static Collection<String> wordActions = new TreeSet<>(Arrays.asList(


Would Set.of do the job?

Perhaps, List.of would be as good.

OK, this is updated to Set.of

Thanks! Using Set ensures there are no duplicates in the list.

This is in response to: https://github.com/openjdk/jdk/pull/25688/files#r2246362320

This is in response to: https://github.com/openjdk/jdk/pull/25688/files#r2255241147

openjdk · 2025-08-06T13:35:29Z

⚠️ @mickleness the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8358813
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java

…est.java Co-authored-by: Alexey Ivanov <[email protected]>

mickleness · 2025-08-06T21:41:05Z

/integrate

openjdk · 2025-08-06T21:42:00Z

@mickleness
Your change (at version e618df3) is now ready to be sponsored by a Committer.

aivanov-jdk · 2025-08-07T10:20:17Z

Client tests are green. I ran a job yesterday with the latest updates.

aivanov-jdk · 2025-08-07T10:20:24Z

/sponsor

openjdk · 2025-08-07T10:22:00Z

Going to push as commit 8d73fe9.
Since your change was applied there have been 44 commits pushed to the master branch:

c56fb0b: 8364503: gc/g1/TestCodeCacheUnloadDuringConcCycle.java fails because of race printing to stdout
487cc3c: 8359690: New test TestCPUTimeSampleThrottling still fails intermittently
078d0d4: 8364235: Fix for JDK-8361447 breaks the alignment requirements for GuardedMemory
... and 41 more: https://git.openjdk.org/jdk/compare/57553ca1dbc63e329116bc11764816a4c5ccb297...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-08-07T10:22:19Z

@aivanov-jdk @mickleness Pushed as commit 8d73fe9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

aivanov-jdk · 2025-08-07T10:54:16Z

@mickleness You should associate your GitHub account with your OpenJDK id, follow the instructions in Associating your GitHub account and your OpenJDK username.

After that, I also recommend following the instructions in the OpenJDK Email section.

8358813: remove more bindings for JPasswordFields in Aqua

7d1c3e8

openjdk bot added the client [email protected] label Jun 9, 2025

turbanoff reviewed Jun 11, 2025

View reviewed changes

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java Outdated Show resolved Hide resolved

Update test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordT…

e5acb92

…est.java Co-authored-by: Andrey Turbanov <[email protected]>

openjdk bot added the rfr Pull request is ready for review label Jun 27, 2025

honkar-jdk reviewed Jun 27, 2025

View reviewed changes

mickleness changed the title ~~8358813: remove more bindings for JPasswordFields in Aqua~~ 8358813: JPasswordField identifies spaces in password via delete shortcuts Jun 27, 2025

aivanov-jdk suggested changes Jul 11, 2025

View reviewed changes

mickleness added 3 commits July 11, 2025 23:09

Merge branch 'master' into JDK-8358813

f7efe89

8358813: make input map types a static constant

53ebb03

This is in response to: openjdk#25688 (comment)

8358813: putting the actions in a TreeSet

6b497a7

This is in response to: openjdk#25688 (comment)

DamonGuy reviewed Aug 1, 2025

View reviewed changes

Update test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordT…

486f575

…est.java Co-authored-by: DamonGuy <[email protected]>

aivanov-jdk reviewed Aug 5, 2025

View reviewed changes

mickleness added 3 commits August 5, 2025 19:39

8358813: add trailing comma

fa7514e

This is in response to: https://github.com/openjdk/jdk/pull/25688/files#r2246362320

Merge branch 'master' into JDK-8358813

3d20804

8358813: use Set.of

58f0178

This is in response to: https://github.com/openjdk/jdk/pull/25688/files#r2255241147

aivanov-jdk approved these changes Aug 6, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2025

aivanov-jdk reviewed Aug 6, 2025

View reviewed changes

test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordTest.java Outdated Show resolved Hide resolved

Update test/jdk/javax/swing/JPasswordField/PasswordFieldInputMapWordT…

e618df3

…est.java Co-authored-by: Alexey Ivanov <[email protected]>

openjdk bot removed the ready Pull request is ready to be integrated label Aug 6, 2025

DamonGuy approved these changes Aug 6, 2025

View reviewed changes

aivanov-jdk approved these changes Aug 6, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 6, 2025

openjdk bot added the integrated Pull request has been integrated label Aug 7, 2025

openjdk bot closed this Aug 7, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 7, 2025

8358813: JPasswordField identifies spaces in password via delete shortcuts #25688

8358813: JPasswordField identifies spaces in password via delete shortcuts #25688

Uh oh!

Conversation

mickleness commented Jun 9, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 9, 2025

Uh oh!

openjdk bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 9, 2025

Uh oh!

mickleness commented Jun 9, 2025

Uh oh!

Uh oh!

mlbridge bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk commented Jul 11, 2025

Uh oh!

DamonGuy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Aug 6, 2025

Uh oh!

Uh oh!

mickleness commented Aug 6, 2025

Uh oh!

openjdk bot commented Aug 6, 2025

Uh oh!

aivanov-jdk commented Aug 7, 2025

Uh oh!

aivanov-jdk commented Aug 7, 2025

Uh oh!

openjdk bot commented Aug 7, 2025

Uh oh!

openjdk bot commented Aug 7, 2025

Uh oh!

aivanov-jdk commented Aug 7, 2025

mickleness commented Jun 9, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 9, 2025 •

edited

Loading

mlbridge bot commented Jun 27, 2025 •

edited

Loading